Difference between revisions of "Issue:Call-time pass-by-reference dpl 1.7.9 mw 1.13"

From FollowTheScore
Jump to: navigation, search
Line 23: Line 23:
 
$this->formatSingleItems($pieces, 0);
 
$this->formatSingleItems($pieces, 0);
 
</code>
 
</code>
 +
 +
=== Thanks for finding the bug ===
 +
Yes, I introduced that error in the latest version (it does not show up in my test installations). The fix will be part of the next release.
 +
 +
BTW: The master version of DPL is still the one that I publish on the dpldemo website. You are talking about "rev 50814". Are you talking about bugzilla? Who has put it there?
 +
 +
I think it is time to put the "official master version" of the DPL sources to some official place - but I do not have write access to any subversion repository.
 +
 +
Any help or hint is welcome. [[User:Gero|Gero]] 18:52, 20 May 2009 (UTC)

Revision as of 20:52, 20 May 2009

Description: PHP Warning: Call-time pass-by-reference has been deprecated in C:\inetpub\wwwroot\mediawiki\extensions\DynamicPageList\DynamicPageList2.php on line 3882
Extension / Version: DPL   /   1.7.9
Type / Status: Bug   /   open/answered (self)

Problem

PHP Warning: Call-time pass-by-reference has been deprecated in C:\inetpub\wwwroot\mediawiki\extensions\DynamicPageList\DynamicPageList2.php on line 3882

Fresh install of dpl, getting this error. any help is appreciated!

Reply

ok i looked through the code and it appears this was introduced by accident in rev 50814 of dynamicpagelist2.php

change line 3882 from:
$this->formatSingleItems(&$pieces, 0);

to:

$this->formatSingleItems($pieces, 0);

Thanks for finding the bug

Yes, I introduced that error in the latest version (it does not show up in my test installations). The fix will be part of the next release.

BTW: The master version of DPL is still the one that I publish on the dpldemo website. You are talking about "rev 50814". Are you talking about bugzilla? Who has put it there?

I think it is time to put the "official master version" of the DPL sources to some official place - but I do not have write access to any subversion repository.

Any help or hint is welcome. Gero 18:52, 20 May 2009 (UTC)