View source for Issue:Call-time pass-by-reference dpl 1.7.9 mw 1.13

{{Issue
 |Type        = Bug 
 |Extension   = DPL 
 |Version     = 1.7.9
 |Description = PHP Warning: Call-time pass-by-reference has been deprecated in C:\inetpub\wwwroot\mediawiki\extensions\DynamicPageList\DynamicPageList2.php on line 3882 
 |Status      = closed
}}

== Problem ==
PHP Warning: Call-time pass-by-reference has been deprecated in C:\inetpub\wwwroot\mediawiki\extensions\DynamicPageList\DynamicPageList2.php on line 3882 

Fresh install of dpl, getting this error. any help is appreciated!

== Reply ==
ok i looked through the code and it appears this was introduced by accident in rev 50814 of dynamicpagelist2.php

<code>
change line 3882 from:<br/>
$this->formatSingleItems(&$pieces, 0);

to:

$this->formatSingleItems($pieces, 0);
</code>

=== Thanks for finding the bug ===
Yes, I introduced that error in the latest version (it does not show up in my test installations). The fix will be part of the next release.

BTW: The master version of DPL is still the one that I publish on the dpldemo website. You are talking about "rev 50814" on the MW svn repository. I think it is time to put the "official master version" of the DPL sources to some official place. I will try to get access to the MW subversion repository.  [[User:Gero|Gero]] 08:18, 21 May 2009 (UTC)

=== Codebase 1.7.9 applied ===
The patch was applied on [http://svn.wikimedia.org/viewvc/mediawiki?view=rev&revision=51054 r51054]. [[User:Shinjiman|Shinjiman]] 10:15, 27 May 2009 (UTC)