Issue:%TOTALPAGES% is incorrect when allowUnlimitedResults=true
From FollowTheScore
Description: | |
Extension / Version: | DPL / ? |
Type / Status: | Bug / open |
Problem
If you set allowUnlimitedResults to true (the global variable doesn't work, so I did it in DPLSetup.php), and use count to limit a query, %TOTALPAGES% will be limited (i.e. if you set the count to 10 and there are more than 10 pages, it will still be 10, i.e. the same as %PAGES%) -- Nx / talk 07:34, 28 July 2010 (UTC)
- I found the source of the problem:
if ( !ExtDynamicPageList::$allowUnlimitedResults && $sGoal != 'categories' && strpos($sResultsHeader.$sResultsFooter.$sNoResultsHeader,'%TOTALPAGES%')!==false) $sSqlCalcFoundRows = 'SQL_CALC_FOUND_ROWS';
in DPLMain.php. I think it should be something like this:
if ( (!ExtDynamicPageList::$allowUnlimitedResults || $sCount) && $sGoal != 'categories' && strpos($sResultsHeader.$sResultsFooter.$sNoResultsHeader,'%TOTALPAGES%')!==false) $sSqlCalcFoundRows = 'SQL_CALC_FOUND_ROWS';
-- Nx / talk 07:49, 28 July 2010 (UTC)
Reply
Thaks, I will take this into consideration for the next release. Now taht MW 1.16 seems to be stable, it is time for a new version of DPL. Gero 16:39, 31 July 2010 (UTC)