Issue:Call-time pass-by-reference dpl 1.7.9 mw 1.13

From FollowTheScore
Revision as of 11:15, 27 May 2009 by Shinjiman (talk | contribs)
Jump to: navigation, search
Description: PHP Warning: Call-time pass-by-reference has been deprecated in C:\inetpub\wwwroot\mediawiki\extensions\DynamicPageList\DynamicPageList2.php on line 3882
Extension / Version: DPL   /   1.7.9
Type / Status: Bug   /   open/answered (self)

Problem

PHP Warning: Call-time pass-by-reference has been deprecated in C:\inetpub\wwwroot\mediawiki\extensions\DynamicPageList\DynamicPageList2.php on line 3882

Fresh install of dpl, getting this error. any help is appreciated!

Reply

ok i looked through the code and it appears this was introduced by accident in rev 50814 of dynamicpagelist2.php

change line 3882 from:
$this->formatSingleItems(&$pieces, 0);

to:

$this->formatSingleItems($pieces, 0);

Thanks for finding the bug

Yes, I introduced that error in the latest version (it does not show up in my test installations). The fix will be part of the next release.

BTW: The master version of DPL is still the one that I publish on the dpldemo website. You are talking about "rev 50814" on the MW svn repository. I think it is time to put the "official master version" of the DPL sources to some official place. I will try to get access to the MW subversion repository. Gero 08:18, 21 May 2009 (UTC)

Codebase 1.7.9 applied

The patch was applied on r51054. Shinjiman 10:15, 27 May 2009 (UTC)

Retrieved from "http://followthescore.org/dpldemo/index.php?title=Issue:Call-time_pass-by-reference_dpl_1.7.9_mw_1.13&oldid=12198"