Difference between revisions of "User talk:Shinjiman"
(reply) |
|||
| Line 16: | Line 16: | ||
[[User:Gero|Gero]] 13:20, 16 June 2009 (UTC) | [[User:Gero|Gero]] 13:20, 16 June 2009 (UTC) | ||
| + | |||
| + | :The "-desc" messages can incorporate the i18n description on [[Special:Version]]. The __FILE__ variable is used on getting the currect directory to showing the revision number when it was checkouted via SVN. Also the "?>" at the end of the PHP file it does not needed on MediaWiki usage because it does not affect the functionality, however it does influence about the trailing whitespace at the end (see other PHP file on core or extensions, e.g. [http://svn.wikimedia.org/viewvc/mediawiki?view=rev&revision=23531 r23531]). [[User:Shinjiman|Shinjiman]] 17:59, 16 June 2009 (UTC) | ||
Revision as of 18:59, 16 June 2009
Thanks for uploading DPL 1.8.3 to the Mediawiki SVN!
I saw that you changed the php sources to utf8. I did the same with my development version !.8.5 - not yet published).
The .i18n- file was already in utf8. I did not change it (although you did so). Is that correct?
I incorporated your changes regarding 'dpl-desc' (I think there was an error in language 'zh-hans' in SVN because it said 'dpl-des' instead of 'dpl-desc'.
I added 'path' => __FILE__ and changed the href in the registration in DynamicPageList.php and in the Migration aid source.
I noticed that you deleted the closing php tag in DPLArticle.php. Was that intention or ny accident?
Are there any other changes you made?
BTW: I applied for an SVN account but nobody seems to care, the queue of applicants on http://www.mediawiki.org/wiki/Commit_access_requests keeps growing ...
Gero 13:20, 16 June 2009 (UTC)
- The "-desc" messages can incorporate the i18n description on Special:Version. The __FILE__ variable is used on getting the currect directory to showing the revision number when it was checkouted via SVN. Also the "?>" at the end of the PHP file it does not needed on MediaWiki usage because it does not affect the functionality, however it does influence about the trailing whitespace at the end (see other PHP file on core or extensions, e.g. r23531). Shinjiman 17:59, 16 June 2009 (UTC)
