View source for Issue:%TOTALPAGES% is incorrect when allowUnlimitedResults=true

{{Issue
 |Type        = Bug | Change Request   <-- please select
 |Extension   = DPL | Wgraph | aiSee | Call <-- please select
 |Version     = ?
 |Description = 
 |Status      = open
}}

== Problem ==
If you set allowUnlimitedResults to true (the global variable doesn't work, so I did it in DPLSetup.php), and use count to limit a query, %TOTALPAGES% will be limited (i.e. if you set the count to 10 and there are more than 10 pages, it will still be 10, i.e. the same as %PAGES%) --&nbsp;[[User:Nx|<span style="color:teal">'''''Nx'''''</span>]]&nbsp;/&nbsp;[[User talk:Nx|''talk'']] 07:34, 28 July 2010 (UTC)
:I found the source of the problem:

<pre>
		if ( !ExtDynamicPageList::$allowUnlimitedResults 	&& $sGoal != 'categories' 
				&& strpos($sResultsHeader.$sResultsFooter.$sNoResultsHeader,'%TOTALPAGES%')!==false) $sSqlCalcFoundRows = 'SQL_CALC_FOUND_ROWS';
</pre>

in DPLMain.php. I think it should be something like this:

<pre>
		if ( (!ExtDynamicPageList::$allowUnlimitedResults || $sCount) && $sGoal != 'categories' 
				&& strpos($sResultsHeader.$sResultsFooter.$sNoResultsHeader,'%TOTALPAGES%')!==false) $sSqlCalcFoundRows = 'SQL_CALC_FOUND_ROWS';
</pre>

--&nbsp;[[User:Nx|<span style="color:teal">'''''Nx'''''</span>]]&nbsp;/&nbsp;[[User talk:Nx|''talk'']] 07:49, 28 July 2010 (UTC)

== Reply ==

Thaks, I will take this into consideration for the next release. Now taht MW 1.16 seems to be stable, it is time for a new version of DPL. [[User:Gero|Gero]] 16:39, 31 July 2010 (UTC)