Difference between revisions of "Issue:Mode=category loses letter headings when ordermethod=titlewithoutnamespace"

Revision as of 18:59, 10 December 2009

Problem

MediaWiki 1.15.1.

This produces the headings A, B, C, etc., like a category page:

<dpl>
category = African Union member states
mode = category
ordermethod = title
</dpl>

Example:

C

• Cameroon

N

• Nigeria

S

• Somalia
• Sudan

This should produce A, B, C, etc., but does not:

<dpl>
category = African Union member states
mode = category
ordermethod = titlewithoutnamespace
</dpl>

Example:

C

• Cameroon

N

• Nigeria

S

• Somalia
• Sudan

I think the headings are empty or blank, not missing. If you have many items in your list, you will see continuation headings like "cont." instead of "A cont." So I'm guessing the headings are being rendered, but they are blank, so nothing shows up. Here is an example with "cont.":

Analysis

In this situation, when ordermethod=titlewithoutnamespace, DPLArticle->mStartChar is not being set. This is happening because in DPLMain.php, formatCategoryList() says:

if( isset($row->sortkey) ) {
 $dplArticle->mStartChar = $wgContLang->convert($wgContLang->firstChar($row->sortkey));
} 

but $row->sortkey is not set. I changed it to

if( isset($row->sortkey) ) {
 $dplArticle->mStartChar = $wgContLang->convert($wgContLang->firstChar($row->sortkey));
} else {
 $dplArticle->mStartChar = $wgContLang->convert($wgContLang->firstChar($row->page_title));
}

and things seem to work. What do you think of this patch? It looks like mStartChar is unused in DPL, except for category mode, so this should be pretty safe...?

Better code:

$startChar = isset($row->sortkey) ? $row->sortkey : $row->page_title;
$dplArticle->mStartChar = $wgContLang->convert($wgContLang->firstChar($startChar));

Reply